Using Node 12 for SPFx (#509)

.github/workflows/pr-package-spfx-dev.yml

@@ -13,44 +13,15 @@ jobs:
         with:
           ref: ${{ github.head_ref }}
 
-      - name: Setup Node.js 10.x
+      - name: Setup Node.js 12.19.0
         uses: actions/setup-node@v1
         with:
-          node-version: 10.x
-
-      - name: (@Shared) Cache node modules
-        id: shared_node_modules_cache
-        uses: actions/cache@v2
-        with:
-          path: SharePointFramework/@Shared/node_modules
-          key: node-modules-${{ hashFiles('SharePointFramework/@Shared/package.json') }}
-
-      - name: (PortfolioWebParts) Cache node modules
-        id: portfolio_webparts_node_modules_cache
-        uses: actions/cache@v2
-        with:
-          path: SharePointFramework/PortfolioWebParts/node_modules
-          key: node-modules-${{ hashFiles('SharePointFramework/PortfolioWebParts/package.json') }}
-
-      - name: (ProjectExtensions) Cache node modules
-        id: project_extensions_node_modules_cache
-        uses: actions/cache@v2
-        with:
-          path: SharePointFramework/ProjectExtensions/node_modules
-          key: node-modules-${{ hashFiles('SharePointFramework/ProjectExtensions/package.json') }}
-
-      - name: (ProjectWebParts) Cache node modules
-        id: project_webparts_node_modules_cache
-        uses: actions/cache@v2
-        with:
-          path: SharePointFramework/ProjectWebParts/node_modules
-          key: node-modules-${{ hashFiles('SharePointFramework/ProjectWebParts/package.json') }}
+          node-version: 12.19.0
 
       - name: (@Shared) Install npm packages
-        if: steps.shared_node_modules_cache.outputs.cache-hit != 'true'
         working-directory: ./SharePointFramework/@Shared
         run: |
-          npm install --no-progress --loglevel silent --no-shrinkwrap --no-fund
+          npm ci
 
       - name: (@Shared) Run npm script build
         working-directory: ./SharePointFramework/@Shared
@@ -63,10 +34,9 @@ jobs:
           npm run lint     
 
       - name: (ProjectWebParts) Install npm packages
-        if: steps.project_webparts_node_modules_cache.outputs.cache-hit != 'true'
         working-directory: ./SharePointFramework/ProjectWebParts
         run: |
-          npm install --no-progress --loglevel silent --no-shrinkwrap --no-fund
+          npm ci
 
       - name: (ProjectWebParts) Run npm script package:ci
         working-directory: ./SharePointFramework/ProjectWebParts
@@ -79,10 +49,9 @@ jobs:
           npm run lint
 
       - name: (PortfolioWebParts) Install npm packages
-        if: steps.portfolio_webparts_node_modules_cache.outputs.cache-hit != 'true'
         working-directory: ./SharePointFramework/PortfolioWebParts
         run: |
-          npm install --no-progress --loglevel silent --no-shrinkwrap --no-fund
+          npm ci
 
       - name: (PortfolioWebParts) Run npm script package:ci
         working-directory: ./SharePointFramework/PortfolioWebParts
@@ -95,10 +64,9 @@ jobs:
           npm run lint
 
       - name: (ProjectExtensions) Install npm packages
-        if: steps.project_extensions_node_modules_cache.outputs.cache-hit != 'true'
         working-directory: ./SharePointFramework/ProjectExtensions
         run: |
-          npm install --no-progress --loglevel silent --no-shrinkwrap --no-fund
+          npm ci
 
       - name: (ProjectExtensions) Run npm script package:ci
         working-directory: ./SharePointFramework/ProjectExtensions

.gitignore

@@ -2,7 +2,6 @@ Install/SiteScripts/*.txt
 Install/InstallLog.txt
 release/*
 SharePointFramework/**/.vscode/launch.json
-SharePointFramework/**/package-lock.json
 SharePointFramework/**/pnpm-lock.yaml
 SharePointFramework/**/shrinkwrap.yaml
 Templates/Portfolio/*.txt
@@ -11,5 +10,4 @@ Templates/*.txt
 Templates/Resources.json
 .DS_Store
 SharePointFramework/**/config/config.backup.json
-**/package-lock.json 
 node_modules

.vscode/settings.json

@@ -6,7 +6,6 @@
         "**/lib": true,
         "**/dist": true,
         "**/temp": true,
-        "**/package-lock.json": true,
         "**/pnpm-lock.yaml": true,
         "README.md": true,
         "dev/README.md": true

SharePointFramework/@Shared/.nvmrc

@@ -1 +1 @@
-10
+12

SharePointFramework/@Shared/README.md

@@ -1,4 +1,4 @@
-## Shared [![version](https://img.shields.io/badge/version-1.2.11-yellow.svg)](https://semver.org)
+## Shared [![version](https://img.shields.io/badge/version-1.2.13-yellow.svg)](https://semver.org)
 
 Shared code for the SharePoint Framework solutions in PP365.