Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade does not remove/replace deprecated pages #588

Closed
tarjeieo opened this issue Oct 21, 2021 · 3 comments
Closed

Upgrade does not remove/replace deprecated pages #588

tarjeieo opened this issue Oct 21, 2021 · 3 comments
Assignees
@tarjeieo
Labels
bug Something isn't working
Milestone
1.3.0

Comments

@tarjeieo
Copy link
Member

Describe the bug
An upgrade does not remove/replace Leveranseoversikt, Erfaringslogg and Risikooversikt. They are left broken in the menu and needs to be manually fixed after upgrade.

Expected behavior
The pages should be removed on upgrade.

I've observed that the pages are not removed because the app-packages are updated first, which removes the old web part instances. This causes Get-PnPClientSideComponent to bomb while trying to find the pages with deprecated webparts.

The solutions is to move the removal of deprecated pages to before app-packages are updated.
@tarjeieo tarjeieo added the bug Something isn't working label Oct 21, 2021
@tarjeieo tarjeieo added this to the 1.3.0 milestone Oct 21, 2021
@tarjeieo tarjeieo self-assigned this Oct 21, 2021
tarjeieo added a commit that referenced this issue Oct 21, 2021
@tarjeieo
Moved removal of deprecated pages #588
d7f6b1e
@okms
Copy link
Contributor

okms commented Oct 21, 2021

Is it a workaround to run -Upgrade with -SkipAppPackages first? Obviously the sequencing must be fixed.

@tarjeieo tarjeieo mentioned this issue Oct 21, 2021
Merged
6 tasks
tarjeieo added a commit that referenced this issue Oct 21, 2021
@tarjeieo
Moved removal of deprecated pages #588 (#589)
0ff6597 
* Moved removal of deprecated pages #588

* Updated changelog

* typo
@olemp
Copy link
Collaborator

olemp commented Oct 25, 2021

@tarjeieo Was this fixed in 0ff6597 and can be closed?

@tarjeieo
Copy link
Member Author

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarjeieo tarjeieo

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@okms @tarjeieo @olemp