Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulighet for søk på personer med mer på porteføljeforside #1283

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

Remi749
Copy link
Collaborator

@Remi749 Remi749 commented Oct 16, 2023

Pull request (PR)

Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot riktig release-branch (venstre side). Sjekk commits og alle commit-meldingene.

Sjekklisten din

Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.

  • Sjekk at din branch ikke feiler på linting.
  • Legg ved beskrivelse i CHANGELOG, markert med ID av issue knyttet til PR-en
  • Angi korrekt Milestone på PR-en og issuet, samt tilegn deg selv PR-en og legg til labels

Beskrivelse

Det er lagt inn mulighet for å søke på mer enn bare "strings", det er mulig å søke på personer (array), prosjekttyper, tjenesteområde (objekt) og ellers alt det andre som finnes i "ProjectListModel"

Hvordan teste

Vennligst beskriv hvordan noen andre (en vanlig bruker uten kodeferdigheter) kan teste denne PR-en. Følg eksempelet under, punktene du legger ved vil bli brukt når vi tester neste versjon av Prosjektportalen

# Handling Forventet resultat
1 Søk etter eier eller leder Resultater skal vise prosjekter hvor eier eller leder er angitt
2 Søk etter prosjekttype eller tjenesteområder Resultater skal vise prosjekter hvor prosjekttype eller tjenesteområde er angitt
3 Deretter utfør... Her skal...

Relevante issues (hvis aktuelt)

Sjekkliste for godkjenner

Alle sjekkpunktene under må være sjekket av og godkjent av reviewers for at vi skal kunne merge branchen din mot dev.

  • Sjekk at det er fylt ut testpunkter
  • Sjekk om det er nødvendig å nevne denne PR i release notes

@Remi749 Remi749 added enhancement Request that will enhance the product complexity: small Issue/PR with small complexity labels Oct 16, 2023
@Remi749 Remi749 added this to the 1.9 milestone Oct 16, 2023
@Remi749 Remi749 self-assigned this Oct 16, 2023
@Remi749
Copy link
Collaborator Author

Remi749 commented Oct 16, 2023

@olemp , gjerne forbered måten jeg har endret søket på her for å inkludere arrays og objekter hvis du ser en bedre måte å gjøre det på

@@ -81,7 +81,15 @@ export const useProjectList = (props: IProjectListProps) => {
.filter((project) => state.selectedVertical.filter(project, state))
.filter((project) =>
_.any(Object.keys(project), (key) => {
const value = project[key]
let value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan vi ikke bare søke i en stringified versjon av value?

cc @Remi749 @tarjeieo

Copy link
Collaborator Author

@Remi749 Remi749 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, blir kanskje treff på mer unødvendige strenger da?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godt poeng. Mulig det blir match i object keys f.eks.

ChatGPT sier følgende:

image

Det ser ikke dumt ut.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sikkert ikke dumt, men blir det ikke akkurat det samme jeg gjør? Bare en annen måte å samle items på...

Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fungerer dette 🎉

@Remi749 Remi749 merged commit 69427e4 into releases/1.9 Oct 16, 2023
2 of 3 checks passed
@Remi749 Remi749 deleted the issues/1281 branch October 16, 2023 11:06
Remi749 added a commit that referenced this pull request Feb 7, 2024
* Fix for 3.1 #1267

* Fixed 2.4/2.5 in #1267

* Setting contentAfter in SearchBox to nul until we find a better solution #1267

* Fix for 2.7 in #1267

* Fix for 2.8 in #1267

* Fix for 2.2 #1267

* Visuell oppgradering av fasevelger (#1270)

* Redesign ProjectPhase, use arrows and make dynamic

* Make callout work for new projectphases

* Responsiveness to phases with flex ++ phaseSubText placement

* Add default PhaseSubText values to 'Fase' Taxonomy

* Minor styling

* Popover content styling + finishing touches

* Minor styling

* string for Start and end arrow labels

* Linting to fix build issues

* Fix for 2.10 #1267

* Attempting to fix Build-Release.ps1 for CI

* Added RunRushCommand

* Build-Release adjustment for CI

* Build-Release.ps1: npm i @microsoft/rush@5.98.0 -g >$null 2>&1

* ColumnContextMenu is using Menu from @fluentui/react-components (later it should be refactored to be in List and shared between components)

* Fix for 3.2 #1267

* Update/Add PhaseSubText/PhaseDescription for Bygg/Anlegg and Program

* Flip icons for sorting ascending/descending to match label

* Minor adjustment [skip-ci]

* Update Prosjektinnholdskolonner + GtTag and Timelineline list columns

* Fix bug with WebPartTitle infoLabel rendering behind content

* Fix for 2.12 in #1267

* Fix for 3.4 in #1267

* ProjectInformation now loading in project status #1267

* Støtte for Usikkerhet-tiltak i Planner (#1273)

* Added ClientSideComponentId to GtRiskAction (#1273)

* Script for å legge til gruppen Porteføljeadministratorer på eksisterende prosjekter (#1275) [skip-ci]

* Visuelt løft på redigeringspanel for prosjektinformasjon (#1272) [skip-ci]

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* Fixed an issue with state updates in RiskActionPlanner (#1273)

* ASSIST-5153: Uncomment of line 91 in script (#1276)

* Adjustments to "Globale innstillinger" view

* Sørger for at eksisterende områder får GtRiskActionPlanner (#1273) (#1278)

* CustomEditPanel som delt komponent som kan brukes av både Prosjektinformasjon og Prosjektstatus (#1279)

* Visuelt løft på paneler for redigering av visninger/kolonner (Porteføljeoversikt/Aggregerte) (#1280)

* linting deliciousness

* Added automatic chores workflow [skip-ci]

* adjustments that should trigger automatic chores

* typo in automatic_chores.yml - should trigger on releases/1.9 (for now)

* automatic_chores should run rush update

* no, rush install

* fixed typo [skip-ci]

* need to use relative import in EditPropertiesPanel [skip-ci]

* GH_TOKEN => GITHUB_TOKEN

* relative import of data in useEditPropertiesPanelSubmit [skip-ci]

* automatic_chores using AUTOMATIC_CHORES_GH_TOKEN

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/dev/.github/workflows/automatic_chores.yml.

* fixed typo in commit messsage for automatic_chores [skip-ci]

* Minor adjustments to transition and styling ProjectList/LatestProjects

* Minor bugfix

* Mulighet for søk på personer med mer på porteføljeforside (#1283)

* Add possiblity to search in arrays (manager, owners)  and tax fields

* Linting...

* Changelog

* Custom panel for Prosjektstatus (#1282)

* DetailsCallout refactored to DetailsPopover

* Fiks for 4.1 i #1267 (#1284)

* Fix for single user field sync #1267

* Fix for 2.14 #1267

* Removed caching from fetchProjectContentColumns causing issue 2.15 #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* ProjectInformationField => EditableSPField

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for 2.11 #1267 (#1285)

* Visuelt løft på prosjektstatus og matriser (#1286)

* Corrections for status fields

* Change default props

* Adjustments to toolbar button font + iconCatalog

* Use new shared Toolbar

* Add a TabList component for sections

* Add new styling to sections

* Linting...

* Adjustments to tooltip

* Make adjustments to other sections

* Update Risk matrix default colors

* Update DynamicMatrix webpart

* Edit styling for snapshot

* Linting

* linting

---------

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* Update components overview [skip-ci]

* Update readme to norwegian [skip-ci]

* Fix for 2.6 (#1267)

* Fix tiny visual bug with Toolbar [skip-ci]

* Minor color and font-size adjustment for currentPhase [skpi-ci]

* skipfeature deployment for PortfolioExtensions and only add to hub via Templates

* Remove override -SkipFeatureDeployment parameter in Install script

* Abort mission, revert!

* Initielt custom skjema for prosjekttidslinje - ikke helt fullført (#1288)

* Use react-components

* Remove assets included with PortfolioExtensions, add to CustomActions

* Update with new guids + channel configs + SiteScripts

* Testing - Skip pre-install step

* Revert [skip-ci]

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Mulig fiks for 3.7 i #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for 3.8 i #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for 3.10 i #1267

* Update packages, remove outdated preview components

* Use new MessageBar instead of Alert in shared component: UserMessage

* Visuelt løft for idémodulen

* Visuelt løft på dialog for endring av fase (#1289)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Visuelt løft og endringer på footer (#1290)

* Update Konfigurasjon page

* Add new icons to iconCatalog

* Add editorconfig to all solutions

* Update footer and buttons

* Finish install version popover

* Add tooltip to version button

* Update information in version popover

---------

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for 3.11 fra #1267 (#1292)

* Switch PlannerTitle, planTitle first, then project title [skip-ci]

* Fiks for 3.13 fra #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Minor positioning change of milestones (diamond and triangles) [skip-ci]

* Use stable InfoLabel component [skip-ci]

* Fix issues with FluentProvider - Footer

* Use IdPrefixProvider for Fluent component, apply to WebPartTitle component + cleanup

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Build-Release.ps1: Checking potential issues with npm run generate-site-scripts

* Reverted manifest ID for footer (was changed in PR #1290)

* Hand error loading page when no report existed ++

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Bruk av UserMessage gjennom hele løsningen (#1293)

* Update UserMessage and FieldContainer component

* ColumnSearchPropertyField UserMessage adjustments

* Update UserMessages in PortfolioWebParts

* Use UserMessage instead of Alert and MessageBar (PortfolioWebParts

* ProgramWebParts

* shared-library

* ProjectInformation

* ProjectExtensions

* Use message consistency throughout solution

* Minor fix

* Another minor fix

* Redesign av Programadministrasjon (#1294)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Refaktorering av FilterPanel (#1296)

* Visuelt løft på Hjelpeinnhold (#1295)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for #998 (#1297)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Visulet løft - Programadministrasjon (#1298)

* PortfolioWebParts

* ProjectWebParts

* shared-library

* Linting....

* footer quickfix for program (helpContent)

* Fix for 4.2 #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Visuelt løft - Filterpanel (#1299)

* Visual overhaul - FilterPanel

* Minor change

* Use Icon component from shared

* Fix for 3.14 #1267

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for #1310

* ProjectSetup._isProjectSetup() now checks if WelcomePage equals 'SitePages/ProjectHome.aspx'

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Adjusted ProjectSetup._isProjectSetup() as some customers might have custom frontpage names

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* GtStatus*: High=>Medium=>Low

* Innføre nivå for Hjelpeinnhold (#1309)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1312 (#1313)

* Oppdaterte lenke til Prosjektveiviseren (https://prosjektveiviseren.digdir.no) #1311 [skip-ci]

* Forbedringer tiltakshåndtering (#1317)

See #1315

* Fix for "Name cannot begin with the '&' character, hexadecimal value 0x26. Line 8, position 1143." [skip-ci]

* Program-feltnavn i programmer (#1314)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1318

* Fix for #1341

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fix for #1339 [skip-ci]

* Update fluent ui packages and use new theme utility to match site themes

This fixes #1307

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Adjustment to lighter portion of fluent ui theme

* Add missing "Lenker" list with links

* Minor fix - GtLinkUrl

* Fix for #1322 og #1324 [skip-ci]

* Fix for #1336 [skip-ci]

* Fix for #1335 [skip-ci]

* Fix for #1320

* Fix for #1326, #1327 og #1325

* Fix for #1300

* Fix for #1331

* Fix for #1303

* Fix for #1333

* Fix issues with 'Datakilder' list

* Fix hardcoded url in Konfigurasjon page

* Fix for #1332

* Fix for #1308

* Fix for #1343

* Fix for #1305

* Fix locale for Program and Portfolio

* Prosjektforsiden blir nå vist når prosjektoppsett er ferdig (#1351)

* automatic chores: linting [skip-ci]

This is a commit done by the GitHub action https://github.com/Puzzlepart/prosjektportalen365/blob/releases/1.9/.github/workflows/automatic_chores.yml.

* Fiks for programtidslinje (#1352)

* Footer skal også vises for medlemmer (#1353)

* NoCrawl="true" for Prosjektdata (#1354)

* Fiks for GtRiskAction (#1357)

* Fix for #1363

* Update workflows

* Correct main channel component id's

* Fix for #1368

* Add title to links list so that UpdateBehavior skip works [skip-ci]

* Add missing string to ProgramWebParts [skip-ci]

* Aggregated list/fields changes cleanup

* Fix grammar for function comments [skip-ci]

* Minor cleanup [skip-ci]

* Translate dev guides to norgwegian + cleanup [skip-ci]

* Update Readmes

* Update README.md

* Update README.md

* Fix missing title in ProgramAdministration webpart

* Updated changelog with all new additions, improvements and fixes

* Update and init 1.9.0 release notes [skip-ci]

* Add smoketest issue template [test]

* Minor update to 1.9.0 releasenotes

* Fix problem with componentId for ideaProcessing

* Update releasenotes for 1.9.0 [skip-ci]

* Finish 1.9.0 visual overhaul release notes [skip-ci]

* Update all old photos from release notes + update footer section [skip-ci]

* Finish releasenotes for 1.9.0 [skip-ci]

* Add idea module related content to Projectportal configuration page

* Update version for shared package to 1.9.0.0 [test]

* CI [upgrade-all-sites-to-latest]

* Fix for #1390 [skip-ci]

* Add EnsureFooterExtension [upgrade-all-sites-to-latest]

* Disable various features for aggregated webpart [upgrade-all-sites-to-latest]

set as isParentProject

* Fix for #1416 [skip-ci]

* Fix issues with Program aggregated webparts for updating columns/views

* Add missing data source [skip-ci]

* Fix UpgradeAllSitesToLatest - aggregated webparts [skip-ci]

* Add missing locale strings for ProgramWebParts (aggregated overviews ++)

* Update scripts to ensure program aggregation webparts have the correct setup for 1.9.0 [skip-ci]

This had to be done due to deprecated data sources still in use

* Add additonal missing locale strings for ProgramWebParts + fixes to strings in PortfolioWebParts

* Even more locale strings missing from ProgramWebParts

* Another one...

* Update JsonTemplates for Program and Parent

* CI [test]

* Fix problems with Program/aggregated functionality for creating columns/views and changing order ++

* Linting...

* Move shared functions for Portfolio/Aggregating to shared PortalDataService [skip-install]

* Rework logic for adding columns to data sources

also fix bugs regarding creating/editing columns

* Fix problem with deleting columns from aggregated webparts + cleanup and improvements [skip-ci]

* Fix issues creating/deleting columns from Program aggregated lists

* Fix for issue where a published statusreport wasn't indicated as published top right [skip-ci]

* Fix issues with missing data i 'Økonomi' statussection #1419 #1380

* Fix for #1400

* Fix problems with creating columns in portfoliowebpart [skip-ci]

* Fix problem creating columns from PortfolioOverview webpart (Program) [skip-ci]

* Additional locale strings ++

* Fix problems with FluentProvider styling not working properly for all components

* Fix issue with PortfolioWebParts crashing [skip-ci]

* Fix RiskActionPlanner script when upgrading + various templates changes [skip-ci]

* Minor fix to smoketest issue template [skip-ci]

* Rework some of the functionality to deactivate ability to move hidden columns in EditViewColumnsPanel

Also add additonal aria's

* Always show uncategorized ProjectContentColumns for all aggregated categories

* Fix issues where users could change view while waiting for a newly changed view

* Fix for #1418 [skip-install]

* Properly hide 'SiteTitle' columns from project level aggregated views [skip-ci]

* Fix for #1443

* Fix for #1449

* Fix for #1397

* Fix for #1453

* Add message in FilterPanel if it is empty #1444

* Fix for #1403 [skip-ci]

* Actual fix for #1403

* Fix for #1393 [skip-ci]

* Fix for #1411 [skip-ci]

* Fix for #1384 [skip-ci]

* Partial fix for #1399 [skip-ci]

* Fix for #1424

* Fix issue with Project admin roles not working properly #1420

* Partial fix for #1454

* Adjustments to required fields and logic in EditPanels for PortfolioWebParts [skip-install]

* Remove mentions in changelog and releasenotes for #1225 as this doesn't work [skip-ci]

To be fixed/added in 1.9.0

* Fix for #1454

* Update build-release to include test channel build [skip-ci]

* Temporary disable of Add and Edit columns from overviews/aggregated webparts [skip-ci]

* Linting after merge [skip-ci]

---------

Co-authored-by: Ole Martin Pettersen <olemp@puzzlepart.com>
Co-authored-by: trondoe <trondoe@puzzlepart.com>
Co-authored-by: github-automatic-chores <github-automatic-chores@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: small Issue/PR with small complexity enhancement Request that will enhance the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants