Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping overwrite of default content #440

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Skipping overwrite of default content #440

merged 2 commits into from
Mar 18, 2021

Conversation

tarjeieo
Copy link
Member

@tarjeieo tarjeieo commented Mar 18, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add PR description to CHANGELOG with the ID that matches this PR

Description

Skipping overwrite of default content to better support customizations.

How to test

Please describe how someone else can test this PR. In the form of a numbered list and checkboxes for Jan when the testing period occurs.

Example:

  • 1. Do modifications of portfolio views, columns, column configuration and insights graphs
  • 2. Update PP to new version
  • 3. Verfiy that customizations are not lost

Relevant issues (if applicable)

💔Thank you!

@tarjeieo tarjeieo marked this pull request as ready for review March 18, 2021 11:18
@tarjeieo tarjeieo requested a review from olemp as a code owner March 18, 2021 11:18
@tarjeieo tarjeieo requested a review from Remi749 March 18, 2021 11:19
@olemp
Copy link
Collaborator

olemp commented Mar 18, 2021

What if we need to change the default config?

@tarjeieo
Copy link
Member Author

What if we need to change the default config?

We can always add new items. Don't see a scenario where we need to change existing - and in my opinion it's more important to "honor" customer customizations.

@olemp olemp merged commit 49b7fe1 into dev Mar 18, 2021
@olemp olemp deleted the fix/overwrite branch March 18, 2021 13:30
@pzljanb pzljanb added this to the 1.2.7 milestone Apr 13, 2021
@pzljanb pzljanb mentioned this pull request Apr 14, 2021
18 tasks
@pzljanb
Copy link
Contributor

pzljanb commented Apr 16, 2021

[x] Removed 'Målsetting' from 'Avsluttede prosjekter'
[ ] Added group by 'Tjenesteområde' on 'Alle prosjekter'
[x] Removed 'Export to Excel' button on 'Erfaringslogg'
[x] Enabled 'Show as etikett' on 'Konsekvens' column in 'Risikooversikt'

Awaiting next upgrade of PP365 installation ...

@pzljanb
Copy link
Contributor

pzljanb commented Apr 22, 2021

Etter update fungerte de fleste lokale tilpasninger som tiltenkt, med unntak av :
[ ] Added group by 'Tjenesteområde' on 'Alle prosjekter'
Denne må testes en gang til...

@pzljanb
Copy link
Contributor

pzljanb commented Apr 23, 2021

Etter update fungerte de fleste lokale tilpasninger som tiltenkt, med unntak av :
[ ] Added group by 'Tjenesteområde' on 'Alle prosjekter'
Denne må testes en gang til...

Da er den siste også testet med vellykket resultat :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants