Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Last Report Date" to Portfolio Overview "Project Status" view #456

Merged
merged 6 commits into from
Apr 23, 2021

Conversation

Petterandre
Copy link
Contributor

@Petterandre Petterandre commented Apr 13, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add PR description to CHANGELOG with the ID that matches this PR

Description

Adds:
GtLastReportDate column and adds to ProjectStatus CT.
Adds element to Prosjektkolonner list with ID 30
Adds ID 30 to default "Project Status" view
Adds "Created" date to title on Project status page. (Will be used later in Snapshots)
Updates the field when clicking on "Publish report" in project.

How to test

  1. Create a new project report.
  2. Publish the report.
  3. View SitePages/Porteføljeoversikt.aspx

Relevant issues (if applicable)

Closes #393

Note:
Does not use "Modified" date from the list element, meaning it does not work retroactively for already published documents as per suggestion in the issue.
💔Thank you!

@Petterandre Petterandre requested a review from olemp as a code owner April 13, 2021 13:56
@Petterandre Petterandre marked this pull request as draft April 13, 2021 13:59
@Petterandre Petterandre marked this pull request as ready for review April 13, 2021 14:00
@Petterandre Petterandre marked this pull request as draft April 13, 2021 14:04
@Petterandre Petterandre marked this pull request as ready for review April 13, 2021 14:20
@olemp
Copy link
Collaborator

olemp commented Apr 22, 2021

@Petterandre can you resolve conflicts

@olemp olemp self-assigned this Apr 22, 2021
@Petterandre
Copy link
Contributor Author

@Petterandre can you resolve conflicts

@olemp Done and Done.

@olemp olemp merged commit a482bed into dev Apr 23, 2021
@olemp olemp deleted the issue/393 branch April 23, 2021 08:59
@pzljanb pzljanb added this to the 1.2.7 milestone Apr 27, 2021
@pzljanb
Copy link
Contributor

pzljanb commented Apr 27, 2021

Error when no previous reports. Has to be handled.

@pzljanb
Copy link
Contributor

pzljanb commented May 5, 2021

Handled nicely in new PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants