Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle 'Idea addon' directly #778

Merged
merged 27 commits into from
Oct 4, 2022
Merged

Bundle 'Idea addon' directly #778

merged 27 commits into from
Oct 4, 2022

Conversation

Remi749
Copy link
Collaborator

@Remi749 Remi749 commented Sep 29, 2022

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Draft PR: changes and additions are subject to change

Changes:

Fields with changed internal names also has new GUID's. These are added to the PostInstallUpgrade.ps1 script and data will be merged correctly.

  • Fields (Idebehandling)

    • GtIdeaExpectedGain => GtIdeaExpectedGains
    • GtIdeaExecutionResourceNeeds => GtIdeaExecutionPlanResourceNeeds
    • GtIdeaExecutionSuccessFactors => GtIdeaExecutionPlanSuccessFactors
    • New Choice for GtIdeaDecision
  • Commandbar icons changed

  • ListViewCommand

    • Added better handling of approved idea registrations and processing (scrapped for now, todo in a later issue)
    • Added information dialog for better information regarding what will happen when users approves/rejects registrations/processing elements (scrapped for now, todo in a later issue)
  • ProjectInformation webpart

    • Added prop to turn on use of Ideaprocessing to be able to sync properties from the new list Prosjektdata with a callout dialog for more information about what this does (see images)
    • New button Synkroniser prosjektegenskaper
    • New dialog for synchronizing properties

image

Additions:

  • New SharePointFramework package: PortfolioExtensions
  • New npm package: pp365-portfolioExtensions
  • Fields
    • CustomFormatting for fields have been added directly with the provisioning
      • GtIdeaUrl, GtIdeaRecommendation and GtIdeaDecision
  • Lists
    • Prosjektdata
      • This list has most of the SiteFields found in Prosjekter list
      • List is used to syncronized project properties to projects
  • ListViewCommand
    • Opprett prosjektdata command has been added to Idébehandling list
      • This created a new element in Prosjektdata list, connects this item to the element selected in Idébehandling and then opens an EditForm for the new element.

How to test

  1. Create and register idea, approve this
  2. Fill out element in 'Idébehandlingsliste', approve this
  3. Create 'Prosjektdata' through the dialog for the and approved element
  4. Fill out SiteUrl for 'Prosjektdata' element
  5. Go to the project where 'useIdeaProcessing' is activated
  6. Press button: 'Synkroniser prosjektegenskaper'
  7. See that the values from 'Prosjektdata' are synchronized to 'Prosjektegenskaper' and afterwards synchronized to portfoliolist 'Prosjekter'

Relevant issues (if applicable)

#777

@Remi749 Remi749 added enhancement Request that will enhance the product priority: high Issue with high priority complexity: large Issue/PR with large complexity backend Related to backend/apis frontend Related to frontend customer funded Issues funded by customer labels Sep 29, 2022
@Remi749 Remi749 added this to the 1.7.0 milestone Sep 29, 2022
@Remi749 Remi749 self-assigned this Sep 29, 2022
@Remi749 Remi749 marked this pull request as ready for review October 4, 2022 08:35
@olemp olemp changed the title Bundle 'Idea addon' directly 'Prosjektportalen365' Bundle 'Idea addon' directly Oct 4, 2022
@olemp olemp merged commit 3417dd8 into dev Oct 4, 2022
@olemp olemp deleted the issue/#777 branch October 4, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend/apis complexity: large Issue/PR with large complexity customer funded Issues funded by customer enhancement Request that will enhance the product frontend Related to frontend priority: high Issue with high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants