Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show status report summary on the front page #368 #868

Merged
merged 31 commits into from
Nov 2, 2022
Merged

Show status report summary on the front page #368 #868

merged 31 commits into from
Nov 2, 2022

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Nov 2, 2022

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Show status report summary on the front page. It can be toggled on and off in the web part properties and required data will only be fetched if it's set to visible.

image

It's set to be hidden by default.

image

If Avkort kommentarer is set it will truncate the comments to the specified length and show the full status element in a tooltip.

image

Relevant issues (if applicable)

#368

@olemp olemp marked this pull request as ready for review November 2, 2022 12:51
@Remi749
Copy link
Collaborator

Remi749 commented Nov 2, 2022

@olemp, Would like to see a screenshot when there are visual changes, when possible could you add to the PR?

@olemp olemp linked an issue Nov 2, 2022 that may be closed by this pull request
@olemp
Copy link
Collaborator Author

olemp commented Nov 2, 2022

@olemp, Would like to see a screenshot when there are visual changes, when possible could you add to the PR?

This is stil in progress :) My bad.

@olemp olemp marked this pull request as draft November 2, 2022 13:14
@olemp olemp self-assigned this Nov 2, 2022
@olemp olemp added this to the 1.8.0 milestone Nov 2, 2022
@olemp olemp added enhancement Request that will enhance the product frontend Related to frontend labels Nov 2, 2022
@olemp olemp marked this pull request as ready for review November 2, 2022 13:40
@olemp
Copy link
Collaborator Author

olemp commented Nov 2, 2022

@olemp, Would like to see a screenshot when there are visual changes, when possible could you add to the PR?

See PR description <3

@olemp olemp merged commit 754d0f9 into dev Nov 2, 2022
@olemp olemp deleted the issues/368 branch November 2, 2022 13:47
@Remi749
Copy link
Collaborator

Remi749 commented Nov 2, 2022

Looks good, though it will take up a lot of space, how about only showing icons instead and have the tooltip like you've shown in the screenshot?

@Remi749
Copy link
Collaborator

Remi749 commented Nov 2, 2022

Like this:
image

@olemp
Copy link
Collaborator Author

olemp commented Nov 2, 2022

Like this:

image

I will add a setting for only showing icon in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request that will enhance the product frontend Related to frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show status report summary on the front page
2 participants