Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skjul tom '? Hjelp tilgjengelig' linje dersom hjelpeinnhold ikke er definert for siden #975

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

Remi749
Copy link
Collaborator

@Remi749 Remi749 commented Feb 10, 2023

Pull request (PR)

Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot dev-branchen (venstre side). Sjekk commits og alle commit-meldingene.

Sjekklisten din

Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.

  • Sjekk at din branch ikke feiler på linting.
  • Legg ved beskrivelse i CHANGELOG, markert med ID av issue knyttet til PR-en
  • Anig korrekt Milestone på PR-en og issuet
  • Tilegn deg selv PR-en og legg til labels

Beskrivelse

Denne feilrettingen vil skjule tom '? Hjelp tilgjengelig' linje dersom hjelpeinnhold ikke er definert for siden.

Før Etter
image image

Hvordan teste

# Handling Forventet resultat
1 Gå til en side som ikke har hjelp innhold definert Tom linje skal ikke vises (se før/etter bilder i PR)

Relevante issues (hvis aktuelt)

@Remi749 Remi749 added the bug Something isn't working label Feb 10, 2023
@Remi749 Remi749 added this to the 1.8 milestone Feb 10, 2023
@Remi749 Remi749 self-assigned this Feb 10, 2023
@Remi749 Remi749 marked this pull request as ready for review February 10, 2023 10:17
@olemp
Copy link
Collaborator

olemp commented Feb 10, 2023

Er det ikke helt klart. @Remi749?

image

@Remi749
Copy link
Collaborator Author

Remi749 commented Feb 10, 2023

Er det ikke helt klart. @Remi749?

image

Joda, bare jeg som har glemt å sjekke av puinktene

Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Remi749 Remi749 added this pull request to the merge queue Feb 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 10, 2023
@olemp olemp self-requested a review February 10, 2023 13:03
@Remi749 Remi749 added this pull request to the merge queue Feb 10, 2023
@Remi749 Remi749 removed this pull request from the merge queue due to a manual request Feb 10, 2023
@Remi749 Remi749 added this pull request to the merge queue Feb 10, 2023
@Remi749 Remi749 removed this pull request from the merge queue due to the queue being cleared Feb 10, 2023
@Remi749 Remi749 added this pull request to the merge queue Feb 10, 2023
@Remi749 Remi749 removed this pull request from the merge queue due to a manual request Feb 10, 2023
@Remi749 Remi749 merged commit 2a1962b into dev Feb 10, 2023
@Remi749 Remi749 deleted the bug/helpcontent-emptyline branch February 10, 2023 14:25
olemp pushed a commit that referenced this pull request Feb 13, 2023
…efinert for siden (#975)

* Hide div if helpContent length is 0

* Update changelog
Remi749 added a commit that referenced this pull request Feb 14, 2023
* Vise alle prosjekter i Administrasjon webdel for program #972

* Updated columns

* addChildProjects

* Filter to remove items with GtSiteIdOWSTEXT 00000000-0000-0000-0000-000000000000

* Vise alle prosjekter i 'Oversikt' webdel (Prorgam) (#973)

* Cleanup old unused strings

* Fixed issue where all projects wasn't loaded in fetchDataForViewBatch

* Changelog

* Add check for context when running SyncProjectDialog

* Update PR workflow [skip-ci]

* Skjul tom '? Hjelp tilgjengelig' linje dersom hjelpeinnhold ikke er definert for siden (#975)

* Hide div if helpContent length is 0

* Update changelog

* Fiks for Planneroppgaver som ikke blir opprettet dersom de mangler plannavn (#977)

* Add default planner names to 'Listeinnhold'

* Renaming of SiteField GtPlannerName

* If no planner name is defined, fallback to title

* Changelog

* Show status report and parent project default on ProjectInformation wp (#979)

* Fikset problem med 'Usikkerhetsoversikt' kategori mangel (#981)

* Set correct helpcontent for 'Usikkerhetsoversikt'

* Correct wrong GtDataSourceCategory

* Fikse problem med prosjektutlistingswebdel (#983)

* Fix searchBox placeholder showing wrong amount

* Add message if no projects are found

* Updated fetchChildProjects and removed title property from title column

* Linting + changelog

---------

Co-authored-by: Bloom <remi.blom-ohlsen@puzzlepart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants