Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Twig_Markup Usage for Compatibility with Pico 3.0 #10

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

PxaMMaxP
Copy link
Owner

@PxaMMaxP PxaMMaxP commented Dec 3, 2023

Introduction

This Pull Request addresses the compatibility issue with the Pico:pico-3.0 branch, as discussed in Issue iridescent-dev#16.

Change Details

  • Updated the usage of Twig_Markup to \Twig\Markup to align with the changes in PicoCMS 3.0.
  • The modification ensures that the plugin remains compatible with PicoCMS 3.0 while maintaining backward compatibility with older versions.

Code Modification

- $twigVariables['toc'] = new Twig_Markup($this->toc_element_xml, 'UTF-8');
+ $twigVariables['toc'] = new \Twig\Markup($this->toc_element_xml, 'UTF-8');

Impact

  • This change is critical for the plugin to function correctly with the latest version of PicoCMS (Pico 3.0).
  • Ensures that the plugin remains usable for users who upgrade to PicoCMS 3.0, as well as those on older versions.

@PxaMMaxP PxaMMaxP merged commit 4a8ab1d into main Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant