Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data from Movimiento table. #36

Merged
merged 12 commits into from
Jul 10, 2021

Conversation

Juerodriguez
Copy link
Contributor

@Juerodriguez Juerodriguez commented Jun 23, 2021

Resumen

close Juerodriguez#11

Este PR permite descargar todos los archivos de la tabla movimiento en un zip
Corresponde a la issue: #10.

Checklist

  • Variables, funciones y comentarios en Español
  • Corrector ortográfico ok
  • Cdigo Python cumple PEP8
  • Cobertura de tests con Playwright
  • Revisores asignados (pares & al menos 1 mentor)

Screenshots

Captura de pantalla de 2021-06-23 13-12-02

test_upload_expedientes_chromium.mp4
test_download_chromium.mp4

@Juerodriguez
Copy link
Contributor Author

Juerodriguez commented Jun 25, 2021

Cambie el formato de videos de playwright a mp4 para hacer posible la subida de los mismos a github @eamanu @marian-vignau

controllers/expedientes.py Outdated Show resolved Hide resolved
controllers/expedientes.py Outdated Show resolved Hide resolved
controllers/expedientes.py Outdated Show resolved Hide resolved
controllers/expedientes.py Outdated Show resolved Hide resolved
@eamanu
Copy link
Collaborator

eamanu commented Jun 25, 2021

@Juerodriguez also check that tests are failling https://github.com/PyAr/OpenLex/pull/36/checks?check_run_id=2911412429

Let me know if you need help

git push origin masterMerge branch 'master' of https://github.com/Juerodriguez/OpenLex into fix-10-exportfiles
@Juerodriguez
Copy link
Contributor Author

@Juerodriguez also check that tests are failling https://github.com/PyAr/OpenLex/pull/36/checks?check_run_id=2911412429

Let me know if you need help

I could see that this dont work because I forget commit one line change.
Now I upload that with suggest changes

@Juerodriguez Juerodriguez mentioned this pull request Jul 1, 2021
5 tasks
@Juerodriguez Juerodriguez requested a review from eamanu July 2, 2021 23:44
controllers/expedientes.py Show resolved Hide resolved
Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize zip download by folders
3 participants