Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #215 #316

Closed
wants to merge 3 commits into from
Closed

Fixes Issue #215 #316

wants to merge 3 commits into from

Conversation

its-ChaTTy
Copy link
Contributor

@its-ChaTTy its-ChaTTy commented Mar 6, 2024

Summary

Closes Issue #215 . Also fixes links as referred #213 & #214 but the APIs used in these sections of lecture TWP45 are broken & are showing external error.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

image

Copy link

@@ -17,7 +17,7 @@ En este ejercicio vamos a acceder a Reddit para obetener datos como los de la si
import json

# La url de Reddit a la que accederemos
url = "https://cors.bridged.cc/http://www.reddit.com/r/Python/.json"
url = "https://api.allorigins.win/raw?url=http://www.reddit.com/r/Python/.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS error still exists

@@ -17,7 +17,7 @@ In this exercise we are going to access Reddit to obtain data like the one in th
import json

# The Reddit URL we'll access
url = "https://cors.bridged.cc/http://www.reddit.com/r/Python/.json"
url = "https://api.allorigins.win/raw?url=http://www.reddit.com/r/Python/.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS error still exits and lecture not working

import json

api_url = "https://tastedive.com/api/similar"
proxy = "https://cors.bridged.cc/"
proxy = "https://api.allorigins.win/raw?url="
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS still not working

@@ -62,7 +68,8 @@ se transforma a un diccionario de Python. Sin embargo, no es del todo legible. E
import json

api_url = "https://tastedive.com/api/similar?"
proxy = "https://cors.bridged.cc/"
proxy = "https://api.allorigins.win/raw?url="
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too, CORS

@its-ChaTTy
Copy link
Contributor Author

Hey, Thanks for the review @sujith-rek, the reddit api error has been fixed. Whereas the API for TasteDive is broken & can not be fixed , https://tastedive.com/api/similar?q=red+hot+chili+peppers%2C+pulp+fiction , you can see it here (this link was taken from TasteDive API Documentation. You can see it here https://tastedive.com/read/api)

Copy link

@sujith-rek
Copy link
Collaborator

see if you merge main into this branch to restore the original polls

@its-ChaTTy its-ChaTTy closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants