Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wscpe entry point #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Wscpe entry point #103

wants to merge 4 commits into from

Conversation

shivamshan
Copy link
Collaborator

@shivamshan shivamshan commented Feb 16, 2022 •
edited
Loading

Summary

This PR adds entry point for newly added WSCPE service.

  • adding entry point allows the service to be called just via typing the name of the service rather than calling the script

Checklist

  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)

Code Evidence

$ wscpe

para soporte de WebClient debe instalar httplib2
Creando TRA...
Firmando TRA...
Conectando a WSAA...
Llamando WSAA...
Grabando TA en C:\Users\shiva\pyafipws\venv_py3\lib\site-packages\pyafipws-3.7.b_2639_-py3.7.egg\pyafipws\cache\TA-0cdbff974c190f6f645f5ded464e65e6.xml...xml...

@shivamshan
corrected download link for certificates
5a8b3f0 
Signed-off-by: Shivam Shandilya <shivam.stpaulsdarjeeling@gmail.com>
@shivamshan
updated setup config file to add entry point for wscpe.py
1b1e3b9 
Signed-off-by: Shivam Shandilya <shivam.stpaulsdarjeeling@gmail.com>
@shivamshan
modified wscpe.py to allow entry point creation
3544b59 
Signed-off-by: Shivam Shandilya <shivam.stpaulsdarjeeling@gmail.com>
@shivamshan
formatted wscpe.py using black and flake8
aad23c1 
Signed-off-by: Shivam Shandilya <shivam.stpaulsdarjeeling@gmail.com>
shivamshan
shivamshan commented Feb 25, 2022
View reviewed changes
setup.cfg
@@ -31,6 +31,7 @@ console_scripts =
wsbfev1 = pyafipws.wsbfev1:main
wscdc = pyafipws.wscdc:main
wscoc = pyafipws.wscoc:main
wscpe = pyafipws.wscpe:main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added wscpe service as an entry point

shivamshan
shivamshan commented Feb 25, 2022
View reviewed changes
wscpe.py


if __name__ == "__main__":
main()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added all functionality under main function, so entry point can be created

NicolasSandoval
NicolasSandoval approved these changes Apr 17, 2022
View reviewed changes
Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution @shivamshan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasSandoval NicolasSandoval Awaiting requested review from NicolasSandoval

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivamshan @NicolasSandoval