Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get all required dependencies in setup.py from issue #105 #112

Closed
wants to merge 6 commits into from
Closed

feat: get all required dependencies in setup.py from issue #105 #112

wants to merge 6 commits into from

Conversation

HanslettTheDev
Copy link
Collaborator

@HanslettTheDev HanslettTheDev commented Mar 27, 2023 •
edited
Loading

Summary

This pull request solves this Issue. The setup.py file has some other dependencies which setup.py has to be aware of so as to build the project. This PR solves that issue

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)

Manual test evidence

(attach command-line examples, execution output & logs, etc.)
image

reingart
reingart requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I didn't see pip freeze used in this context, did you have any specific reason to use it?
Nice first approach, please see the review comments in each file and try to address them

get_dep.py Outdated Show resolved Hide resolved
@HanslettTheDev HanslettTheDev requested a review from reingart April 10, 2023 23:55
@HanslettTheDev
feat: get all required dependencies in setup.py from issue PyAr#105
d52925a 
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
feat: get all required dependencies in setup.py from issue PyAr#105
0262bfb 
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
fix: improved the get_dependencies function to grab all dependency mo…
67bbd6c 
…dules

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
fix: improved the get_dependencies function to grab all dependency mo…
6be6c6e 
…dules; commit signed

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
fix: fixed the issue with pip not detecting links
bb768e5 
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
fix: removed the python version number in the requirements.txt file
27de097 
fix: fixed the error when replacing the links with the module name
The overall errors fixed was to prevent the setup.py build from failing

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev
Copy link
Collaborator Author

Sorry, I had to rebase my branch.
I am not used to the signed commits. So I had to rebase then push the signed commits

@HanslettTheDev HanslettTheDev deleted the setup_improvements branch June 15, 2023 23:25
reingart added a commit that referenced this pull request Jan 7, 2024
@reingart
Merge pull request #112 from cperezabo/main
d4562d5 
PyQR: colores de relleno y fondo configurables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reingart reingart Awaiting requested review from reingart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HanslettTheDev @reingart