Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update merge_configuration_file to prefer values from flags #158

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Update merge_configuration_file to prefer values from flags #158

merged 1 commit into from
Oct 9, 2022

Conversation

fsouza
Copy link
Collaborator

@fsouza fsouza commented Oct 9, 2022

The idea is that options set with flags take precedence over options set in the configuration file (any configuration file).

@fsouza
Update merge_configuration_file to prefer values from flags
5928483 
The idea is that options set with flags take precedence over options set
in the configuration file (any configuration file).
@fsouza fsouza mentioned this pull request Oct 9, 2022
Merged
3 tasks
kynan
kynan approved these changes Oct 9, 2022
View reviewed changes
Copy link

@kynan kynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

@fsouza fsouza merged commit 5928483 into main Oct 9, 2022
@fsouza fsouza deleted the fix-config-order branch October 9, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kynan kynan kynan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsouza @kynan