Pytorch fix #1231
Merged
Pytorch fix #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyTorch plugin (B614) has been updated to properly handle the weights_only parameter in torch.load calls. When weights_only=True is specified, PyTorch will only deserialize known safe types, making the operation more secure. I also removed torch.save as there is no certain insecure element as such, saving any file or artifact requires consideration of what it is you are saving. Changes: - Update plugin to only check torch.load calls (not torch.save) - Fix weights_only check to handle both string and boolean True values - Remove map_location check as it doesn't affect security - Update example file to demonstrate both safe and unsafe cases - Update plugin documentation to mention weights_only as a safe alternative The plugin now correctly identifies unsafe torch.load calls while allowing safe usage with weights_only=True to pass without warning. Fixes: PyCQA#1224
sigmavirus24
approved these changes
Feb 10, 2025
ericwb
reviewed
Feb 10, 2025
ericwb
reviewed
Feb 14, 2025
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
ericwb
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B614: Fix PyTorch plugin to handle weights_only parameter correctly
The PyTorch plugin (B614) has been updated to properly handle the weights_only parameter in
torch.loadcalls. Whenweights_only=Trueis specified, PyTorch will only deserialize known safe types, making the operation more secure.I also removed
torch.saveas there is no specific insecure case as such, saving any file or artifact requires consideration of what it is you are saving and along with the legitimacy of the source input for the saved object.Changes:
The plugin now correctly identifies unsafe torch.load calls while allowing safe usage with weights_only=True to pass without warning.
Fixes: #1224