Avoid printing metrics as float point numbers #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
requested review from
ghugo,
lukehinds and
sigmavirus24
as code owners
The metrics in the output was displaying counts as floats instead of integers. For example, 15.0 instead of 15. This is due to a divide call using '/' instead of '//' which rounds down the answer. We shouldn't have fractional number results anyway since the counts are always divisible by the rank values. Signed-off-by: Eric Brown <browne@vmware.com>
sigmavirus24
approved these changes
Feb 4, 2022
This was referenced Feb 28, 2022
Merged
Merged
chore(deps): update pre-commit hook pycqa/bandit to v1.7.3
browniebroke/flake8-django-migrations#174
Merged
This was referenced Feb 28, 2022
Merged
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics in the output was displaying counts as floats instead
of integers. For example, 15.0 instead of 15. This is due to a
divide call using '/' instead of '//' which rounds down the answer.
We shouldn't have fractional number results anyway since the counts
are always divisible by the rank values.
Signed-off-by: Eric Brown browne@vmware.com