weak_cryptographic_key assumes positional arg #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
force-pushed
the
weak_crypto_keyword
branch
from
27d6652
to
30ae1ca
Compare
The weak_cryptographic_key assumes a positional arg when it doesn't find a value for the keyword arg. The issue is that sometimes the keyword arg is a ast.Call or other undeterminate values. And as a result throws a Traceback. This change will make the plugin a little more robust so it doesn't throw the Traceback. It won't be able determine the value of the curve in this case, but can ignore it. Fixes PyCQA#545 Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
ericwb
force-pushed
the
weak_crypto_keyword
branch
from
30ae1ca
to
05d2763
Compare
sigmavirus24
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weak_cryptographic_key assumes a positional arg when it doesn't
find a value for the keyword arg. The issue is that sometimes the
keyword arg is a ast.Call or other undeterminate values. And as
a result throws a Traceback.
This change will make the plugin a little more robust so it doesn't
throw the Traceback. It won't be able determine the value of the
curve in this case, but can ignore it.
Fixes #545
Signed-off-by: Eric Brown eric_wade_brown@yahoo.com