Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct number of arguments to match the %s placeholders. #934

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Pass correct number of arguments to match the %s placeholders. #934

merged 1 commit into from
Jul 14, 2022

Conversation

mportesdev
Copy link
Contributor

Pull request #913 didn't adjust the arguments to be interpolated in the logging message (arguments do not match the %s placeholders). As a result, there is an unhandled TypeError and failed string interpolation. This change fixes that.

Before:

image

After:

image

Pass correct number of arguments to match the `%s` placeholders.
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@ericwb ericwb merged commit fe055fd into PyCQA:main Jul 14, 2022
@mportesdev mportesdev deleted the debug_log branch July 15, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants