Recover from corrupted cache file #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Do you think it would be possible to add a test for this situation? The code doesn't look ready for that (actually that rply code) but maybe you would have an idea. I'm curious about how you got this bug. Are you running (red?)baron in a highlight concurrent environment? Thanks for your contribution, |
|
@Psycojoker I could imagine simply modifying the file randomly can cause this. Makes sense to protect from external inputs as much as possible. Would you be okay with a test mocking external functions? |
|
Thanks for your contribuer :) |
|
@Psycojoker any chance this could make it into a PyPI release? I'm encountering this bug in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows baron to recover in case the cache file has invalid JSON by deleting and recreating it. Before, it would fail with an exception on initialization.