Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621: Migrate more config into pyproject.toml #110

Merged
merged 3 commits into from
Sep 24, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 24, 2022

Migrate configuration settings out of setup.cfg into pyproject.toml using ini2toml to do the file conversion and then run validate-pyproject to validate the results.

  • flake8 is not currently compatible with pyproject.toml so migrate its config into .flake8.
  • Comment out tool.setuptools.use-scm-version which does not pass validate-pyproject.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move! I know it will upset few people due pip problems with editable installs but that should not be good enough reason to prevent it.

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Sep 24, 2022
@ssbarnea ssbarnea merged commit e488bc9 into PyCQA:main Sep 24, 2022
@cclauss cclauss deleted the ini2toml branch September 24, 2022 15:30
@cclauss
Copy link
Contributor Author

cclauss commented Sep 24, 2022

Thx. Do you know of a good source of info on the editable installs issue?

@ssbarnea
Copy link
Member

ssbarnea commented Sep 24, 2022

@cclauss That is the infamous bug pypa/pip#7953 but I learnt to avoid it.

Two workarounds: either use pyenv, and in that case you have user-level python, so you do not need to user --user option when installing stuff, or the more common approach, always use a virtualenv/venv as the editable problem does not happen with these.

PS. I will not make a release only with this patch as I do not find it worth a new release. OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants