Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a new release to include python_venv fix for pre-commit compatibility #294

Closed
yuema137 opened this issue Oct 15, 2024 · 1 comment
Labels
fresh This is a new issue

Comments

@yuema137
Copy link

yuema137 commented Oct 15, 2024

Hi,

The latest version of pre-commit no longer supports python_venv as a language option, which makes the venv hook causing an error like this (same as #289 ):

==> At Hook(id='docformatter-venv')
    ==> At key: language
    =====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
    Check the log at /pc/pre-commit.log

I noticed that the venv hook in the .pre-commit-hooks.yaml file has been removed in the master branch. However, the latest release (v1.7.5) does not include this fix, and this is causing compatibility issues when installing via pip using pre-commit.

Since the issue has been fixed in the master branch, would it be possible to release a new version so that users installing via pip can benefit from this fix?

Thank you!

@github-actions github-actions bot added the fresh This is a new issue label Oct 15, 2024
@yuema137
Copy link
Author

My bad. Just noticed that it's identical to #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fresh This is a new issue
Projects
None yet
Development

No branches or pull requests

1 participant