pre-commit 4.0.0: InvalidManifestError

[cesarcoatl]

My .pre-commit-config.yaml includes the following:

  - repo: https://github.com/PyCQA/docformatter
    rev: v1.7.5
    hooks:
      - id: docformatter
        args: [--in-place, --wrap-summaries=72, --close-quotes-on-newline]

Error:

$ pre-commit run --all-files                                                          
An error has occurred: InvalidManifestError: 
==> File /Users/cesarcoatl/.cache/pre-commit/repoffw0ifit/.pre-commit-hooks.yaml
==> At Hook(id='docformatter-venv')
==> At key: language
=====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
Check the log at /Users/cesarcoatl/.cache/pre-commit/pre-commit.log

The problematic line of YAML can be found here:

docformatter/.pre-commit-hooks.yaml

Line 13 in 886a032

language: python_venv

Possible solution:

Fix hook

[webknjaz]

@asottile is python_venv easily replaceable with python?

[asottile]

please don't mention me when you can read the docs it has been a warning and alias for years

[webknjaz]

@asottile fair, sorry. Do you have a commit bit to merge #287, though?

[asottile]

@asottile fair, sorry. Do you have a commit bit to merge #287, though?

I do, but only because I'm an org admin so it doesn't seem right for me to do it :S

[weibullguy]

Fixed in PR #290.

[s-weigand]

For anyone who still has this issue.
pre-commit supports defining specific commits out of the box so just use the fix commit 06907d0 (in the end tags are just flippy floppy pointers to commits anyway 😅)
E.g.

  - repo: https://github.com/PyCQA/docformatter
    rev: 06907d0
    hooks:
      - id: docformatter
        additional_dependencies: [tomli]
        args: [--in-place, --config, ./pyproject.toml]

[webknjaz]

rev: 06907d0

Does this work? I remember some tooling only allowing full commit hashes and being unhappy about the short ones.

[nfelt14]

Fixed in PR #290.

It may be fixed in the default branch, but there isn't a release available with the fix yet.

[fepegar]

Does this work?

Yes, @webknjaz.

[crypdick]

rev: 06907d0

Does this work? I remember some tooling only allowing full commit hashes and being unhappy about the short ones.

I can confirm this works.