Skip to content

Commit

Permalink
Try a fix for broken docformatter pre-commit hook
Browse files Browse the repository at this point in the history
- PyCQA/docformatter#289
- PyCQA/docformatter#287

Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
  • Loading branch information
lebrice committed Oct 7, 2024
1 parent 2b1a784 commit a678913
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ repos:
rev: v1.7.5
hooks:
- id: docformatter
language: python
args: [--in-place, --wrap-summaries=99, --wrap-descriptions=99]
require_serial: true

Expand Down

5 comments on commit a678913

@bashierelbashier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lebrice Did this fix the problem?

@MoritzWeber0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work (at least for me).

@bashierelbashier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoritzWeber0 thanks for your response. I just forked the repo and fixed the .pre-commit-hooks.yaml of the revision that we are using. Temporarily until they merge that PR

@lebrice
Copy link
Collaborator Author

@lebrice lebrice commented on a678913 Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is misleading. This did not fix the issue. In the end I ended up restricting pre-commit version < 4.0.0 in my GitHub Actiosn workflow.

@lebrice
Copy link
Collaborator Author

@lebrice lebrice commented on a678913 Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up doing the same as in DSD-DBS/capella-dockerimages@6e38a0c

Please sign in to comment.