Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Try a fix for broken docformatter pre-commit hook
- PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
- Loading branch information
a678913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lebrice Did this fix the problem?
a678913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work (at least for me).
a678913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoritzWeber0 thanks for your response. I just forked the repo and fixed the .pre-commit-hooks.yaml of the revision that we are using. Temporarily until they merge that PR
a678913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is misleading. This did not fix the issue. In the end I ended up restricting pre-commit version < 4.0.0 in my GitHub Actiosn workflow.
a678913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up doing the same as in DSD-DBS/capella-dockerimages@6e38a0c