Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit removed the support for venv #1450

Closed
yuema137 opened this issue Oct 15, 2024 · 1 comment · Fixed by #1453
Closed

Pre-commit removed the support for venv #1450

yuema137 opened this issue Oct 15, 2024 · 1 comment · Fixed by #1453
Labels
bug Something isn't working

Comments

@yuema137
Copy link
Collaborator

yuema137 commented Oct 15, 2024

See this post: https://stackoverflow.com/questions/79057817/invalidmanifesterror-at-key-language-expected-one-of-but-got-python-venv
And the pre-commit config in straxen: https://github.com/XENONnT/straxen/blob/df0d4887fd26a2350dcbec1567bca9aedff8b361/.pre-commit-config.yaml#L23C11-L23C48

Basically, pre-commit doesn't support the keyword venv anymore, but the docformatter repo is still using the venv hook in its .pre-commit-hooks.yaml. This fails all of the pre-commit tests. That hook is already removed in the master branch, but unfortunately not in the latest release.

@yuema137 yuema137 added the bug Something isn't working label Oct 15, 2024
@yuema137
Copy link
Collaborator Author

yuema137 commented Oct 15, 2024

This is a fresh issue fixed only several days ago in docformatter: PyCQA/docformatter#289
There is another issue requesting for a new release:PyCQA/docformatter#293. If it could not happen very soon, we could consider switching to the master branch

@yuema137 yuema137 changed the title Precommit removed the support for venv Pre-commit removed the support for venv Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant