Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Upgrade pre-commit #506

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Upgrade pre-commit #506

merged 2 commits into from
Oct 24, 2024

Conversation

samuelhwilliams
Copy link
Contributor

@samuelhwilliams samuelhwilliams commented Oct 24, 2024

Change description

Bumps our local pre-commit version to be >=4.0. This matches what runs in pre-commit.ci, so is best to keep roughly in sync.

In particular this bump has been prompted by CI failures on the assessment-store, where one of the installed hooks is incompatible with v4 of pre-commit because the python_venv "language" has been removed. We don't see this issue locally on that repo because we're still running an older version of pre-commmit.

See also PyCQA/docformatter#289

Pin docformatter to the current latest commit on master, because it
is otherwise broken with this version of pre-commit (which runs in CI
and so CI is failing).

PyCQA/docformatter#293
Copy link
Contributor

@sfount sfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified in and should resolve #504 and #505

@samuelhwilliams samuelhwilliams merged commit b40874e into main Oct 24, 2024
3 checks passed
@samuelhwilliams samuelhwilliams deleted the bau/update-pre-commit branch October 24, 2024 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants