Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate reshape of x1 in OT #137

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

ScheiklP
Copy link
Contributor

@ScheiklP ScheiklP commented Oct 9, 2024

What does this PR do?

Super small fix, removing a duplicate reshape.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?
❯ pre-commit run -a
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://github.com/PyCQA/isort.
[INFO] Initializing environment for https://github.com/asottile/pyupgrade.
[INFO] Initializing environment for https://github.com/myint/docformatter.
An error has occurred: InvalidManifestError: 
==> File /home/paul/.cache/pre-commit/repop5vzgaf7/.pre-commit-hooks.yaml
==> At Hook(id='docformatter-venv')
==> At key: language
=====> Expected one of conda, coursier, dart, docker, docker_image, dotnet, fail, golang, haskell, lua, node, perl, pygrep, python, r, ruby, rust, script, swift, system but got: 'python_venv'
Check the log at /home/paul/.cache/pre-commit/pre-commit.log

Seems like pre-commit does not like mamba.

Did you have fun?

Thanks a lot for this awesome repo!

@atong01
Copy link
Owner

atong01 commented Oct 9, 2024

Thanks for the PR!

Looks good to me. Looks like upstream breakages. Will merge soon, but will try to patch tests and things first.

See: PyCQA/docformatter#289

@atong01
Copy link
Owner

atong01 commented Oct 9, 2024

Looks like second problem is pinning numpy to 1.26.4 because pandas.

@atong01
Copy link
Owner

atong01 commented Oct 9, 2024

Tests failing here but fixed on main. Merging. Thank you for the PR!

@atong01 atong01 merged commit 39e1930 into atong01:main Oct 9, 2024
8 of 31 checks passed
@ScheiklP ScheiklP deleted the geometric branch October 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants