Fix dependency issues leading to failed actions and remove unused code #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichJackson
approved these changes
Oct 7, 2024
added 11 commits
October 7, 2024 11:02
* docformatter breaks pre-commit on version 4.0. Need to pin this until this issue is resolved: PyCQA/docformatter#289 * in future when this is resolved also need to run `pre-commit migrate-config`
paluchasz
changed the title
paluchasz
changed the title
RichJackson
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classic case of new package updates breaking something in dependencies and pip struggling to find versions that satisfy all requirements.
Spacyversion as it was problematic (it depends on some package calledthincwhich was causing dependencies to not resolve for latest versions of spacy). But it also needed to be >3.4.2 to run on Python 3.11, otherwise cannot evenimport spacy.pre-committo version <4 as the latest release breaks pre-commits altogether if you are using thedocformatterpre-commit. Can't be changed until the following issue gets resolved pre-commit 4.0.0: InvalidManifestError PyCQA/docformatter#289.