-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix ci #3196
Merged
Merged
[Fix] Fix ci #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
force-pushed
the
yehc/update-mypy-versioon
branch
11 times, most recently
from
November 1, 2024 18:11
51681d2
to
872e140
Compare
HAOCHENYE
force-pushed
the
yehc/update-mypy-versioon
branch
from
November 1, 2024 18:21
872e140
to
a0d6c63
Compare
HAOCHENYE
force-pushed
the
yehc/update-mypy-versioon
branch
from
November 1, 2024 19:22
0b68a2f
to
7083af7
Compare
HAOCHENYE
force-pushed
the
yehc/update-mypy-versioon
branch
from
November 1, 2024 19:31
7083af7
to
821a47e
Compare
HAOCHENYE
force-pushed
the
yehc/update-mypy-versioon
branch
from
November 1, 2024 20:04
1202fb4
to
821a47e
Compare
zhouzaida
reviewed
Nov 2, 2024
zhouzaida
reviewed
Nov 2, 2024
zhouzaida
reviewed
Nov 2, 2024
"""This class is the DCN implementation of the MLU device. The MLU | ||
"""This class is the DCN implementation of the MLU device. | ||
The MLU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一行有点奇怪,应该和下面的合在一起?
python 脚本我都看了,没啥问题,但 cpp cu 的格式风格可能要再 check 一下 clang 的版本 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
double-string-fixer
will introduce syntax errors for nested f-strings for Python pre-3.12 versions whenpre-commit
is run by Python 3.12 pre-commit/pre-commit-hooks#971Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: