Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix ci #3196

Merged
merged 4 commits into from
Nov 4, 2024
Merged

[Fix] Fix ci #3196

merged 4 commits into from
Nov 4, 2024

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Nov 1, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@HAOCHENYE HAOCHENYE force-pushed the yehc/update-mypy-versioon branch 11 times, most recently from 51681d2 to 872e140 Compare November 1, 2024 18:11
@HAOCHENYE HAOCHENYE force-pushed the yehc/update-mypy-versioon branch from 872e140 to a0d6c63 Compare November 1, 2024 18:21
@HAOCHENYE HAOCHENYE force-pushed the yehc/update-mypy-versioon branch from 0b68a2f to 7083af7 Compare November 1, 2024 19:22
@HAOCHENYE HAOCHENYE force-pushed the yehc/update-mypy-versioon branch from 7083af7 to 821a47e Compare November 1, 2024 19:31
@HAOCHENYE HAOCHENYE changed the title [Fix] Fix pre-commit-hook for python3.12 [Fix] Fix ci Nov 1, 2024
@HAOCHENYE HAOCHENYE force-pushed the yehc/update-mypy-versioon branch from 1202fb4 to 821a47e Compare November 1, 2024 20:04
"""This class is the DCN implementation of the MLU device. The MLU
"""This class is the DCN implementation of the MLU device.

The MLU
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行有点奇怪,应该和下面的合在一起?

@zhouzaida
Copy link
Collaborator

python 脚本我都看了,没啥问题,但 cpp cu 的格式风格可能要再 check 一下 clang 的版本

@HAOCHENYE HAOCHENYE merged commit 1393257 into main Nov 4, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants