Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for # noqa comments #134

Merged
merged 2 commits into from
Oct 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bugbear.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ def run(self):
visitor = self.visitor(filename=self.filename, lines=self.lines)
visitor.visit(self.tree)
for e in itertools.chain(visitor.errors, self.gen_line_based_checks()):
if pycodestyle.noqa(self.lines[e.lineno - 1]):
continue

if self.should_warn(e.message[:4]):
yield self.adapt_error(e)

Expand Down
7 changes: 0 additions & 7 deletions tests/b001.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,6 @@ def func(**kwargs):
# should be except KeyError:
return

results = something.call(debug=is_debug)
try:
results["ok"]
except: # noqa
# warning silenced
return


try:
pass
Expand Down
5 changes: 0 additions & 5 deletions tests/b901.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,6 @@ async def not_broken4():
return 1


def actually_not_broken():
yield 2
return 1 # noqa


def not_broken5():
def inner():
return 2
Expand Down
1 change: 0 additions & 1 deletion tests/b950.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@
" line is fine "
" line is still fine "
" line is no longer fine by any measures, yup"
" line is no longer fine by any measures but is silenced" # noqa
"line is fine again"
2 changes: 1 addition & 1 deletion tests/test_bugbear.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_b001(self):
expected = self.errors(
B001(8, 0, vars=("bare `except:`",)),
B001(40, 4, vars=("bare `except:`",)),
B001(54, 0, vars=("`except ():`",)),
B001(47, 0, vars=("`except ():`",)),
)
self.assertEqual(errors, expected)

Expand Down