Skip to content

(3.8) Minor tweaks #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cooperlees merged 1 commit into from
Mar 16, 2023
Merged

(3.8) Minor tweaks #368

cooperlees merged 1 commit into from
Mar 16, 2023

Conversation

@FozzieHi
Copy link
Contributor

@FozzieHi FozzieHi commented Mar 14, 2023 •
edited
Loading

Tracking issue: #365

Some minor changes:

  • Changes in bugbear.py and test_bugbear.py from running pyupgrade --py38-plus against them (I left the individual test files, not sure if we want to change those)
  • A change to pyproject.toml setting requires-python to >=3.8.1 instead of >=3.8 to match flake8
  • A change I missed in tox.ini on (3.8) Update CI and metadata #367

Should we also change the flake8 dependency requirement from >=3.0.0 to >=6.0.0?

cooperlees
cooperlees approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - Agree with 3.8.1 - I remember this!

Thanks.

tests/test_bugbear.py
["flake8", str(filename)],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
capture_output=True,
Copy link
Collaborator

@cooperlees cooperlees Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O, TIL, have never used ! NIce.

@cooperlees cooperlees merged commit fc4dde8 into PyCQA:main Mar 16, 2023
@FozzieHi FozzieHi deleted the 3-8-minor-tweaks branch March 16, 2023 17:42
@FozzieHi FozzieHi mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FozzieHi @cooperlees