Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new type error #489

Merged
merged 3 commits into from
May 18, 2024
Merged

Fix new type error #489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0370f1
Fix new type error
JelleZijlstra May 18, 2024
f4ec9ff
Update pyi.py
JelleZijlstra May 18, 2024
f5bbb0f
Add protocol
JelleZijlstra May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pyi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from functools import cached_property, partial
from itertools import chain, groupby, zip_longest
from keyword import iskeyword
from typing import TYPE_CHECKING, Any, ClassVar, NamedTuple, Union
from typing import TYPE_CHECKING, Any, ClassVar, NamedTuple, Protocol, Union

from flake8 import checker
from flake8.options.manager import OptionManager
Expand Down Expand Up @@ -62,6 +62,11 @@ class TypeVarInfo(NamedTuple):
name: str


class NodeWithLocation(Protocol):
lineno: int
col_offset: int


def all_equal(iterable: Iterable[object]) -> bool:
"""Returns True if all the elements are equal to each other.

Expand Down Expand Up @@ -2245,7 +2250,7 @@ def check_arg_default(self, arg: ast.arg, default: ast.expr | None) -> None:
if default is not None and not _is_valid_default_value_with_annotation(default):
self.error(default, (Y014 if arg.annotation is None else Y011))

def error(self, node: ast.AST, message: str) -> None:
def error(self, node: NodeWithLocation, message: str) -> None:
self.errors.append(Error(node.lineno, node.col_offset, message, PyiTreeChecker))

def _check_for_unused_things(self) -> None:
Expand Down
Loading