fix: set a max jobs on win32 to avoid too many handles #1964
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylbert
force-pushed
the
fix/checker/too_many_handles_on_win32
branch
from
0c41943 to
09626c9
Compare
This commit fixes the issue of too many handles on win32 when `--jobs=auto`. This is done by setting the `job_count` to the minimum value between `multiprocessing.cpu_count()` and 61. This happens when a machine has > 61 logic processors and `multiprocessing.cpu_count()` returns a value greater than 61. See [Python Issue 26903](https://bugs.python.org/issue26903) for more information. Example failure for Python 3.10.15 with flake8 7.1.0 on Windows 11: ```bash flake8.EXE myfile.py --jobs=auto Exception in thread Thread-1 (_handle_workers): Traceback (most recent call last): File "lib\threading.py", line 1016, in _bootstrap_inner self.run() File "lib\threading.py", line 953, in run self._target(*self._args, **self._kwargs) File "lib\multiprocessing\pool.py", line 522, in _handle_workers cls._wait_for_updates(current_sentinels, change_notifier) File "lib\multiprocessing\pool.py", line 502, in _wait_for_updates wait(sentinels, timeout=timeout) File "lib\multiprocessing\connection.py", line 879, in wait ready_handles = _exhaustive_wait(waithandle_to_obj.keys(), timeout) File "lib\multiprocessing\connection.py", line 811, in _exhaustive_wait res = _winapi.WaitForMultipleObjects(L, False, timeout) ValueError: need at most 63 handles, got a sequence of length 194 ```
pylbert
force-pushed
the
fix/checker/too_many_handles_on_win32
branch
from
09626c9 to
52cbf91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue of too many handles on win32 when
--jobs=auto. This is done by setting thejob_countto the minimum value betweenmultiprocessing.cpu_count()and 61.See Python Issue 26903 for more information.
Example failure for Python 3.10.15 with flake8 7.1.0 on Windows Server 2022 Standard 21H2: