Do not cache configuration files #1994
Comments
kaste
added a commit
to kaste/isort
that referenced
this issue
Nov 11, 2022
Fixes PyCQA#1994 isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome. Remove the caches in `settings.py` completely to re-read the configuration on each run. This is safe for the CLI case as we here either use the `Trie` implementation which collects all known configuration files beforehand, or we exactly construct one `Config` object based on the first filename, the working dir, or the explicit `settings_path|file` settings. Not caching is therefore more efficient for the CLI case and more useful for the editor case.
kaste
added a commit
to kaste/isort
that referenced
this issue
Feb 8, 2023
Fixes PyCQA#1994 isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome. Remove the caches in `settings.py` completely to re-read the configuration on each run. This is safe for the CLI case as we here either use the `Trie` implementation which collects all known configuration files beforehand, or we exactly construct one `Config` object based on the first filename, the working dir, or the explicit `settings_path|file` settings. Not caching is therefore more efficient for the CLI case and more useful for the editor case.
kaste
added a commit
to kaste/isort
that referenced
this issue
Feb 8, 2023
Fixes PyCQA#1994 isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome. Remove the caches in `settings.py` completely to re-read the configuration on each run. This is safe for the CLI case as we here either use the `Trie` implementation which collects all known configuration files beforehand, or we exactly construct one `Config` object based on the first filename, the working dir, or the explicit `settings_path|file` settings. Not caching is therefore more efficient for the CLI case and more useful for the editor case.
kaste
added a commit
to kaste/isort
that referenced
this issue
Feb 8, 2023
Fixes PyCQA#1994 isort can run in long processes when used in an editor. In that scenario it is confusing for users when editing a configuration file does not change isorts outcome. Remove the caches in `settings.py` completely to re-read the configuration on each run. This is safe for the CLI case as we here either use the `Trie` implementation which collects all known configuration files beforehand, or we exactly construct one `Config` object based on the first filename, the working dir, or the explicit `settings_path|file` settings. Not caching is therefore more efficient for the CLI case and more useful for the editor case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
isort can run in long processes when used in an editor. In that
scenario users might edit their configuration files and literally
save a file again to see its outcome.
This is not possible right now because we
lru_cache()all therelevant functions in
settings.py.It is strange that we do this in the first place as we either collect
all known configs using the
Trieimplementation or we onlyconstruct exactly one
Configobject based on the first file name,the working dir, or from
settings_path|file...We can probably remove the caches in
settings.pycompletely.Except of course you explicitly wanted to optimize for long
running processes.
The text was updated successfully, but these errors were encountered: