Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of new direct dependencies [5.13] #2206

Closed
g-as opened this issue Dec 9, 2023 · 1 comment · Fixed by #2207
Closed

Lots of new direct dependencies [5.13] #2206

g-as opened this issue Dec 9, 2023 · 1 comment · Fixed by #2207

Comments

@g-as
Copy link

g-as commented Dec 9, 2023

Because these entries:

pipfile_deprecated_finder = ["pipreqs", "requirementslib", "pip-shims"]
requirements_deprecated_finder = ["pipreqs", "pip-api"]

were removed from [tool.poetry.extras] but the underlying deps kept in [tool.poetry.dependencies] in #2089, most "optional" deps are now installed by default.

From what I gather from poetry, it doesn't make sense to have deps flagged optional if they're not tied to an extra.

 [[package]]
 name = "isort"
-version = "5.12.0"
+version = "5.13.0"
 description = "A Python utility / library to sort Python imports."
 optional = false
 python-versions = ">=3.8.0"
 files = [
-    {file = "isort-5.12.0-py3-none-any.whl", hash = "sha256:f84c2818376e66cf843d497486ea8fed8700b340f308f076c6fb1229dff318b6"},
-    {file = "isort-5.12.0.tar.gz", hash = "sha256:8bef7dde241278824a6d83f44a544709b065191b95b6e50894bdc722fcba0504"},
+    {file = "isort-5.13.0-py3-none-any.whl", hash = "sha256:15e0e937819b350bc256a7ae13bb25f4fe4f8871a0bc335b20c3627dba33f458"},
+    {file = "isort-5.13.0.tar.gz", hash = "sha256:d67f78c6a1715f224cca46b29d740037bdb6eea15323a133e897cda15876147b"},
 ]

+[package.dependencies]
+pip-api = "*"
+pipreqs = "*"
+requirementslib = "*"
+
 [package.extras]
-colors = ["colorama (>=0.4.3)"]
-pipfile-deprecated-finder = ["pip-shims (>=0.5.2)", "pipreqs", "requirementslib"]
+colors = ["colorama (>=0.4.6)"]
 plugins = ["setuptools"]
-requirements-deprecated-finder = ["pip-api", "pipreqs"]
@sigma67
Copy link

sigma67 commented Dec 12, 2023

Thanks, this had one had me raising some eyebrows on 5.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants