Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff no longer shown when using isort --check-only --diff as of v4.2.9 #553

Closed
edmorley opened this issue Jun 2, 2017 · 2 comments
Closed

Diff no longer shown when using isort --check-only --diff as of v4.2.9 #553

edmorley opened this issue Jun 2, 2017 · 2 comments
Labels
bug Something isn't working

Comments

@edmorley
Copy link
Contributor

edmorley commented Jun 2, 2017 •
edited
Loading

In our CI we use isort --check-only --diff --quiet, so that if there are any errors the diff is shown so developers know what to fix without having to run isort again themselves locally.

This used to work as of v4.2.8, eg:
https://travis-ci.org/mozilla/treeherder/jobs/238235705#L240

However does not in v4.2.9, eg:
https://travis-ci.org/mozilla/treeherder/jobs/238401565#L240

It appears to have been regressed by the return added in:
6bf21fc#diff-7597e4974079b411e5fb6464a449abf1R184
@edmorley edmorley mentioned this issue Jun 2, 2017
Closed
@timothycrosley timothycrosley added the bug Something isn't working label Jun 2, 2017
timothycrosley added a commit that referenced this issue Jun 2, 2017
@timothycrosley
Implement support for both check only and diff, fixing issue #553
ef1bd7f
@timothycrosley
Copy link
Member

Thanks for reporting!

This has been fixed in a 4.2.13 hotfix release

~Timothy

@edmorley
Copy link
Contributor Author

edmorley commented Jun 2, 2017

Many thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edmorley @timothycrosley