-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_imports
option is broken
#651
Comments
Also seeing this when upgrading in adamchainz/django-mysql#424 |
This should now be fixed in release 4.3.1, Thank you! |
I'm sorry, but looks like this is not fixed in version 4.3.1. |
I'm afraid I'm also still seeing the same, updated my previously linked PR |
I'm so sorry! I didn't merge the fix in correctly before distributing the new release to PYPI, this should now be resolved in 4.3.2 |
Works for me thanks! |
Just installed new version of
isort=4.3.0
(on python 3.6).Given this file (
itest.py
):and this config in
setup.cfg
:when I run
isort itest.py
I got this result:When I run same command one more time the result is like this:
If I remove
VAR
from that file and run isort again, the result is as expected:I believe this is a regression as I was unable to reproduce it in version
4.2.15
.This bug makes new version unusable for us, since we have files with multiline strings and
add_imports
setting.The text was updated successfully, but these errors were encountered: