Update line_length and single_line_exclusions in google profile #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jagapiou do you maybe have a link of those changes? |
|
Line-length exemption for imports: https://google.github.io/styleguide/pyguide.html#32-line-length |
|
@staticdev just a ping on this in case it slipped your notifications. Anything else you need me to do? |
dseomn
reviewed
Sep 28, 2023
jagapiou
changed the title
jagapiou
changed the title
dseomn
approved these changes
Sep 29, 2023
|
Sorry for missing this @jagapiou . I see all checks are failing, we cannot merge like this. |
|
No probs :-) I think those failures weren't my change, but the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the google profile to match the style guide