Added a fix for normalizing imports from more than one level of parent modules (issue/2152) #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticdev
reviewed
Dec 4, 2023
isort/identify.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| from pathlib import Path | |||
| from typing import Iterator, NamedTuple, Optional, TextIO, Tuple | |||
|
|
|||
| from isort.parse import _normalize_line, _strip_syntax, skip_line | |||
| from isort.parse import _strip_syntax, normalize_line, skip_line | |||
There was a problem hiding this comment.
Following the same logic, I would rename _strip_syntax to strip_syntax. It will be better if you could also do it ;)
…t modules (issue/2152)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 3089 3090 +1
Branches 748 748
=======================================
+ Hits 3063 3064 +1
Misses 15 15
Partials 11 11 |
|
@staticdev sorry, missed the comment :) It's renamed now. |
staticdev
approved these changes
Dec 10, 2023
|
Thanks @bp72, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2152