Allow --diff to be used with --jobs
#2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bug reported in PyCQA#2216 where `--diff` is ignored when `--jobs` is non-zero. All credit for this fix goes to @ian-h-chamberlain, who reported the bug and found where the fix needed to be applied.
DanielNoord
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
LGTM!
Up to @staticdev whether a test for this is needed, but it seems like a nice fix to get in.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2302 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 40 40
Lines 3098 3098
Branches 788 788
=======================================
Hits 3071 3071
Misses 15 15
Partials 12 12 |
staticdev
added
enhancement
staticdev
approved these changes
Jan 21, 2025
|
Thanks @mnakama and @DanielNoord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug reported in #2216 where
--diffis ignored when--jobsis non-zero.All credit for this fix goes to @ian-h-chamberlain, who reported the bug and found where the fix needed to be applied.