Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on main #2320

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Fix errors on main #2320

merged 3 commits into from
Jan 9, 2025

Conversation

DanielNoord
Copy link
Member

Error that wasn't caught correctly in the CI of #2283

Let's see if this passes CI or if I need to add more fixes :)

@Helveg
Copy link
Contributor

Helveg commented Jan 9, 2025

Oh sorry, that's likely because noone approved the pending workflow runs on my PR, so only DeepSource ever ran, but the other CI never did.

@matthewhughes934
Copy link
Contributor

matthewhughes934 commented Jan 9, 2025

FYI: I did some work to get deps in this repo up-to-date with CI passing on a separate fork matthewhughes934/isort-fork@1326160...16f242a (separate fork because I wanted to make a bunch of PRs in my repo with CI runs, but found it difficult with just 'forking' in github since it target every PR on this repo by default)

@DanielNoord
Copy link
Member Author

@Helveg or @matthewhughes934 Could you review this before I merge it?

@matthewhughes934 Feel free to create PRs for some of those changes. Ideally with multiple smaller scoped PRs as I'm still getting used to this codebase :)

@DanielNoord DanielNoord merged commit 91b8973 into main Jan 9, 2025
35 checks passed
@DanielNoord DanielNoord deleted the fix-main branch January 9, 2025 09:02
@matthewhughes934
Copy link
Contributor

@Helveg or @matthewhughes934 Could you review this before I merge it?

@matthewhughes934 Feel free to create PRs for some of those changes. Ideally with multiple smaller scoped PRs as I'm still getting used to this codebase :)

I have a chain of branches ready to go, they update deps to nearly up to date (up to date as of the day I originally made the commits, so maybe 1 month out of date) and ends with adding dependabot config for the Python deps (to keep them up-to-date):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants