Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Remove warning when __all__ is a list #227

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Remove warning when __all__ is a list #227

merged 1 commit into from
Jan 11, 2017

Conversation

jdufresne
Copy link
Contributor

Refs #62

sigmavirus24
sigmavirus24 suggested changes Jan 9, 2017
View reviewed changes
Copy link
Member

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this is accepted, you should have tests to ensure that the warning isn't re-added.

@jdufresne
Copy link
Contributor Author

Added test. Thanks.

@Nurdok Nurdok merged commit e416156 into PyCQA:master Jan 11, 2017
@Nurdok
Copy link
Member

Nurdok commented Jan 11, 2017

Merged. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 requested changes

@Nurdok Nurdok Nurdok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdufresne @Nurdok @sigmavirus24