Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

WIP: Use Jedi as the underlying parser #240

Closed
wants to merge 16 commits into from
Closed

WIP: Use Jedi as the underlying parser #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
33560ac
Working on using Jedi as a parser engine.
Nurdok Dec 10, 2016
4aca0a3
WIP
Nurdok Dec 11, 2016
7389343
More parser work.
Nurdok Dec 11, 2016
360c7a4
Tests work, except "noqa" parsing.
Nurdok Jan 25, 2017
0012e50
Adding back the "# noqa" feature.
Nurdok Jan 28, 2017
878bc55
All tests pass! Now to make the code pretty...
Nurdok Jan 28, 2017
0b03b94
Install runtime requirements in tox.
Nurdok Jan 28, 2017
d9a00e0
Install runtime requirements in tox.
Nurdok Jan 28, 2017
9b43b05
Trying to fix StringIO error.
Nurdok Jan 30, 2017
c0b2fd0
Another attempt to fix StringIO error.
Nurdok Jan 30, 2017
67b5cc8
Another attempt to fix the encoding issue in Python 2.7.
Nurdok Jan 31, 2017
320f614
Added invalid syntax test; still doesn't pass.
Nurdok Feb 1, 2017
1785df7
Invalid syntax tests pass.
Nurdok Feb 3, 2017
d86c488
Merge branch 'master' into feature/jedi-parser (there are still jedi …
Nurdok Mar 4, 2017
d94e4ba
Pinned jedi version - 0.10.0 has breaking changes (though I used non …
Nurdok Mar 4, 2017
0f3c90f
Removed __init__.py and pin Jedi because of API changes (should remov…
Nurdok Mar 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements/runtime.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
jedi==0.9.0
1 change: 1 addition & 0 deletions requirements/tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ pytest==3.0.2
pytest-pep8==1.0.6
mock==2.0.0
pathlib
-r runtime.txt
3 changes: 3 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
keywords='pydocstyle, PEP 257, pep257, PEP 8, pep8, docstrings',
packages=('pydocstyle',),
package_dir={'': 'src'},
install_requires=[
'jedi',
],
entry_points={
'console_scripts': [
'pydocstyle = pydocstyle.cli:main',
Expand Down
Empty file removed src/__init__.py
View file
Open in desktop
Empty file.
7 changes: 6 additions & 1 deletion src/pydocstyle/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import ast
import string
import sys
import functools
import tokenize as tk
from itertools import takewhile
from re import compile as re
Expand Down Expand Up @@ -330,7 +331,7 @@ def check_unicode_docstring(self, definition, docstring):
For Unicode docstrings, use u"""Unicode triple-quoted strings""".

'''
if definition.module.future_imports['unicode_literals']:
if 'unicode_literals' in definition.module.future_imports:
return

# Just check that docstring is unicode, check_triple_double_quotes
Expand Down Expand Up @@ -680,6 +681,10 @@ def check(filenames, select=None, ignore=None, ignore_decorators=None):
try:
with tokenize_open(filename) as file:
source = file.read()
try:
source = source.decode('utf-8')
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this except should be more narrowly scoped. There are a surprising number of exceptions that can happen here and they depend on platform, how the python interpreter is compiled, etc.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To catch any exception use the except Exception, instead of except BaseException or just except.
Indicate the most specific exception type in except block.
For example:

# Bad
try:
    mapping[key]
except Exception:
    ...

# Better
try:
    mapping[key]
except KeyError:
    ...

pass
for error in ConventionChecker().check_source(source, filename,
ignore_decorators):
code = getattr(error, 'code', None)
Expand Down
Loading