This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix decorator parsing for async functions #577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with parsing decorators right before async function definitions.
A good example to illustrate the issue is
overload
.At the moment, this would emit a D103 error for the first definition.
That's because, parsing the decorator name wasn't stopped with
async
and thusoverload
becameoverloadasync
and didn't match anyis_overload
checks anymore.