Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive in type annotation of recursive data structure. #567

Closed
jonathanslenders opened this issue Jul 25, 2020 · 2 comments
Closed

False positive in type annotation of recursive data structure. #567

jonathanslenders opened this issue Jul 25, 2020 · 2 comments

Comments

@jonathanslenders
Copy link 

from typing import Dict

def test() -> None:
    class Tree(Dict[str, "Tree"]):
        def __missing__(self, key: str) -> "Tree":
            self[key] = Tree()
            return self[key]
/tmp/x.py:4:26 undefined name 'Tree'
PrettyWood added a commit to PrettyWood/pydantic that referenced this issue Dec 24, 2020
@PrettyWood
fix: lint issue (false positive)
ab57d19 
PyCQA/pyflakes#567
PrettyWood added a commit to PrettyWood/pyflakes that referenced this issue Dec 25, 2020
@PrettyWood
fix: support recursive models in local scope
cc71cc0 
closes PyCQA#567
@PrettyWood PrettyWood mentioned this issue Dec 25, 2020
Closed
PrettyWood added a commit to PrettyWood/pyflakes that referenced this issue Dec 25, 2020
@PrettyWood
fix: support recursive models in local scope
c3c0d35 
closes PyCQA#567
PrettyWood added a commit to PrettyWood/pyflakes that referenced this issue Dec 25, 2020
@PrettyWood
fix: support recursive models in local scope
a0e8111 
closes PyCQA#567
samuelcolvin added a commit to pydantic/pydantic that referenced this issue Jan 2, 2021
@PrettyWood @samuelcolvin
fix: force need of update_forward_refs in recursive models (#2221)
43308d1 
* fix: force need of `update_forward_refs` in recursive models

closes #1201

* fix: lint issue (false positive)

PyCQA/pyflakes#567

* chore: avoid if statement for coverage

* fix linting

Co-authored-by: Samuel Colvin <s@muelcolvin.com>
@noirbee noirbee mentioned this issue Apr 25, 2022
Merged
@asottile
Copy link
Member

this as inadvertently fixed by #754

@jonathanslenders
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support type annotation of recursive data structure in local scope PrettyWood/pyflakes
2 participants
@jonathanslenders @asottile