Add too-many-lines #8219
Add too-many-lines #8219
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8219 +/- ##
=======================================
Coverage 95.45% 95.45%
=======================================
Files 177 177
Lines 18635 18635
=======================================
Hits 17788 17788
Misses 847 847 |
There was a problem hiding this comment.
The code in good.py and bad.py should have an equivalent behavior, it hard to have this constraint for this message so it should be a special case where we don't have a good/bad example done in #7897
| @@ -1 +1 @@ | |||
| You can help us make the doc better `by contributing <https://github.com/PyCQA/pylint/issues/5953>`_ ! | |||
| Used when a module has too many lines, reducing its readability. | |||
There was a problem hiding this comment.
You really need to actually check the result before pushing. I told you at least twice already, the description from the checker is automatically added to the doc. What does the checker contain ? "Used when a module has too many lines, reducing its readability." Now what is going to be in the result ? You should generate locally but here goes:
Description:
Used when a module has too many lines, reducing its readability.
....
Additional details:
Used when a module has too many lines, reducing its readability.
Created by the [format](https://github.com/PyCQA/pylint/blob/main/pylint/checkers/format.py) checker.
So what's wrong here ? Yes, the text is duplicated. Do I have to point this out each time ?
Also we have 40 concurrent runners for the whole organization, wasting runner time by pushing new commits all the time before event checking the result locally is impacting dozen of persons, please be more considerate
Type of Changes
Description
Adding documentation for too-many-lines
Refs #5953
Closes #XXXX