Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add too-many-lines #8219

Closed
wants to merge 5 commits into from
Closed

Add too-many-lines #8219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d370c60
Add too-many-lines
ollie-iterators Feb 7, 2023
57906e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2023
8452de8
Adding changes
ollie-iterators Feb 7, 2023
30fafde
Fix good.py
ollie-iterators Feb 7, 2023
dbc279b
Remove pylintrc value
ollie-iterators Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions doc/data/messages/t/too-many-lines/bad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# [too-many-lines]
import datetime
from datetime import datetime

# Make a program to display the various Date Time formats
print("Current date and time: " , datetime.datetime.now())
print("Current year: ", datetime.date.today().strftime("%Y"))
print("Month of year: ", datetime.date.today().strftime("%B"))
print("Week number of the year: ", datetime.date.today().strftime("%W"))
print("Weekday of the week: ", datetime.date.today().strftime("%w"))
print("Day of year: ", datetime.date.today().strftime("%j"))
print("Day of the month : ", datetime.date.today().strftime("%d"))
print("Day of week: ", datetime.date.today().strftime("%A"))
2 changes: 1 addition & 1 deletion doc/data/messages/t/too-many-lines/details.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
You can help us make the doc better `by contributing <https://github.com/PyCQA/pylint/issues/5953>`_ !
Used when a module has too many lines, reducing its readability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You really need to actually check the result before pushing. I told you at least twice already, the description from the checker is automatically added to the doc. What does the checker contain ? "Used when a module has too many lines, reducing its readability." Now what is going to be in the result ? You should generate locally but here goes:

Description:

Used when a module has too many lines, reducing its readability.

....

Additional details:

Used when a module has too many lines, reducing its readability.

Created by the [format](https://github.com/PyCQA/pylint/blob/main/pylint/checkers/format.py) checker.

So what's wrong here ? Yes, the text is duplicated. Do I have to point this out each time ?

Also we have 40 concurrent runners for the whole organization, wasting runner time by pushing new commits all the time before event checking the result locally is impacting dozen of persons, please be more considerate

10 changes: 9 additions & 1 deletion doc/data/messages/t/too-many-lines/good.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
# This is a placeholder for correct code for this message.
import datetime
from datetime import datetime

# Make a program to display the various Date Time formats
dateStrings = ["Current date and time: ", "Current year: "]
dateValues = [datetime.datetime.now(), datetime.date.today().strftime("%Y")]

for index in range(len(dateStrings)):
print(dateStrings[index] + dateValues[index])
2 changes: 2 additions & 0 deletions doc/data/messages/t/too-many-lines/pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[main]
max-module-lines = 10