bug: fix nans in Spread #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem introduced in Spread with latest versions of numba. This is due to the way we used to handle nans, a much cleaner way is used now with math.isnan without having to first convert to integrers.
|
@cako FYI, I just installed pylops on my new mac book air and started to have issues with tests related to the Spread operator; turns out that probably something is changed in numba and the way we were handling nans stopped working... the good news is that it forced me to find a much cleaner way (I think!) to do it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem introduced in Spread with latest versions of numba. This is due to the way we used to handle nans, a much cleaner way is used now with math.isnan without having to first convert to integrers.