New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments on the JOSS paper #166

Closed

ewu63 opened this issue Feb 26, 2024 · 2 comments

ewu63 commented Feb 26, 2024

For reference: openjournals/joss-reviews#6326

Here are some comments I have regarding the paper itself:

In the statement of need, it would be helpful to cite a few well-known packages in order to highlight the key distinguishing features of this package. This is already done in the repo README and can probably be reused.
One DOI is missing -- see here for the suggested DOI

ewu63 mentioned this issue

[REVIEW]: PyProximal - scalable convex optimization in Python openjournals/joss-reviews#6326

Closed

Contributor

mrava87 commented Feb 27, 2024

@nwu63 thanks a lot for the feedback. I will shortly update the paper and let you know so you can check :)

Contributor

mrava87 commented Feb 29, 2024

@nwu63 thanks again for the suggestions, they are now incorporated in the paper.

ewu63 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment