-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PyProximal - scalable convex optimization in Python #6326
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hello again! 👋 FYI @mrava87 This is the review thread for the paper. All of our higher-level communications will happen here from now on, review comments and discussion can happen in the repository of the project (details below). 📓 Please read the "Reviewer instructions & questions" in the comment from our editorialbot (above). ✅ All reviewers get their own checklist with the JOSS requirements - you generate them as per the details in the editorialbot comment. As you go over the submission, please check any items that you feel have been satisfied. 💻 The JOSS review is different from most other journals: The reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention the link to #6326 so that a link is created to this thread. That will also help me to keep track! ❓ Please also feel free to comment and ask questions on this thread if you are unsure about something! 🎯 We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @ewu63Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@ewu63 thanks for getting started! @nirum @Leo-Simpson friendly reminder about your review in this thread. 🙂 |
Review checklist for @nirumConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@ewu63 if you are done with your review (seems like it from your checkmarks), I'd appreciate if you could write a short summary whether you recommend this paper for acceptance or/and if some points still need to be addressed. Same for @nirum once you are finished, please 🙏 @Leo-Simpson I haven't heard back from you in 3 weeks -- would you still like to review this paper? Please just let me know if you cannot make it so that I can find a potential replacement for you. It would be great to have all reviews finished within the next three weeks, approximately. |
@sappelhoff I recommend this paper for acceptance, pending the following points to be addressed:
This is tracked at PyLops/pyproximal#166 |
Thanks @ewu63, I have included now your comments as also written in the Github issue. Let me know if you agree or if you have any further suggestion :) |
@editorialbot generate pdf |
@sappelhoff the authors have addressed all my concerns, I recommend this paper for publication. |
@mrava87 I really enjoyed reading through your repository. I especially appreciated the nice set of tutorials. Overall everything is clearly written and nicely documented. @sappelhoff I recommend for publication |
@nirum thanks a lot! |
@editorialbot check references |
|
Ops, I made a mistake… will fix the broken DOI soon :) |
@editorialbot check references |
|
@sappelhoff done :) |
@editorialbot set 10.5281/zenodo.10805997 as archive |
Done! archive is now 10.5281/zenodo.10805997 |
@editorialbot set v0.8.0 as version |
Done! version is now v0.8.0 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5121, then you can now move forward with accepting the submission by compiling again with the command |
@mrava87 great, thanks! Our job is done for now. Let's wait for the editor in chief to do a final check and ship this :-) |
Great! thanks a lot for guiding me through this @sappelhoff, it has been a pleasure :-) |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@sappelhoff just to confirm that the paper DOI works and everything looks good :) But I do not seem to be able myself to close this issue (point 2), I guess you can... Thanks again everyone, @sappelhoff @nirum and @ewu63! |
Thanks everyone! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @mrava87 (Matteo Ravasi)
Repository: http://github.com/pylops/pyproximal/
Branch with paper.md (empty if default branch): joss
Version: v0.8.0
Editor: @sappelhoff
Reviewers: @nirum, @ewu63
Archive: 10.5281/zenodo.10805997
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@nirum & @ewu63, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sappelhoff know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ewu63
📝 Checklist for @nirum
The text was updated successfully, but these errors were encountered: