Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for 1.0.0 release #1489

Closed
6 of 7 tasks
messense opened this issue Feb 16, 2023 · 2 comments · Fixed by #1625
Closed
6 of 7 tasks

Tracking issue for 1.0.0 release #1489

messense opened this issue Feb 16, 2023 · 2 comments · Fixed by #1625

Comments

@messense
Copy link
Member

messense commented Feb 16, 2023 •
edited
Loading

Breaking Changes

  • move RemainingCoreMetadata over to pyproject.toml

Bug fixes

Documentation

Nice to have
@konstin
Copy link
Member

konstin commented Feb 16, 2023

I think we should also move RemainingCoreMetadata over to pyproject.toml before 1.0. Currently there's a weird split where you need to configure maturin in both Cargo.toml and pyproject.toml; I only realized this when i hit https://www.maturin.rs/project_layout.html#import-rust-as-a-submodule-of-your-project with pep440_rs. Afaik targets = and data = of [package.metadata.maturin] are also currently not part of the docs.

This was referenced Feb 18, 2023
Merged
Merged
@landhb
Copy link

landhb commented Feb 25, 2023

This should no longer be blocked on linux-keyutils. The build has been fixed in the 0.2.3 release.

bors bot added a commit that referenced this issue Mar 25, 2023
@bors @messense
Merge #1493
4db31ed 
1493: Move maturin metadata from `Cargo.toml` to `pyproject.toml` r=konstin a=messense

Implements #1489 (comment)

Co-authored-by: messense <messense@icloud.com>
@hombit hombit mentioned this issue Apr 10, 2023
Closed
@messense messense mentioned this issue May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 1.0.0 messense/maturin
3 participants
@messense @konstin @landhb